Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release scripts): backport fixes for CI from 0.71 into main #35258

Closed
wants to merge 2 commits into from

Conversation

kelset
Copy link
Contributor

@kelset kelset commented Nov 8, 2022

Summary

This PR backport two fixes we did in 0.71 to unblock the release process:

  • the change in publish-npm is needed because of the introduction of .strict() from 4f3ca8f
  • the removal of the other script (added originally here e4b5d3e) is because:
    1. that step is not needed anymore (we don't publish/upload hermes artifacts to the GH release)
    2. by the time this job gets run the release crew has already setup the GH release
    3. the logic for the versioning was broken and even on the 0.71-rc pipeline it was tagging stuff as 1000.0.0

Changelog

[Internal] [Fixed] - Fix release scripts for "release" pipeline scenario

Test Plan

The fact that 0.71-rc0 was released is the ✅ for this.

@kelset kelset requested a review from cipolleschi November 8, 2022 12:42
@kelset kelset requested a review from hramos as a code owner November 8, 2022 12:42
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Nov 8, 2022
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kelset kelset changed the title fix(release scripts): backport fixes from 0.71 into main fix(release scripts): backport fixes for CI from 0.71 into main Nov 8, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dac6806
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @kelset in cfa25e0.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 8, 2022
@kelset kelset deleted the kelset/backport-job-updates-from-71 branch November 8, 2022 19:58
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
)

Summary:
This PR backport two fixes we did in 0.71 to unblock the release process:
* the change in `publish-npm` is needed because of the introduction of .strict() from facebook@4f3ca8f
* the removal of the other script (added originally here facebook@e4b5d3e) is because:
  1) that step is not needed anymore (we don't publish/upload hermes artifacts to the GH release)
  2) by the time this job gets run the release crew has already setup the GH release
  3) the logic for the versioning was broken and even on the 0.71-rc pipeline it was tagging stuff as 1000.0.0

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Fixed] - Fix release scripts for "release" pipeline scenario

Pull Request resolved: facebook#35258

Test Plan: The fact that 0.71-rc0 was released is the ✅ for this.

Reviewed By: jacdebug

Differential Revision: D41120888

Pulled By: cipolleschi

fbshipit-source-id: 06d108f0659ad1db53c6324fe1d735f52c34a3c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants